Skip to content

interfaces: Add canalystii run time libraries#1123

Closed
Cherish-Gww wants to merge 1 commit intohardbyte:developfrom
Cherish-Gww:add_canalystii_so
Closed

interfaces: Add canalystii run time libraries#1123
Cherish-Gww wants to merge 1 commit intohardbyte:developfrom
Cherish-Gww:add_canalystii_so

Conversation

@Cherish-Gww
Copy link

No description provided.

@mergify mergify bot requested a review from hardbyte September 1, 2021 06:52
@Cherish-Gww Cherish-Gww force-pushed the add_canalystii_so branch 2 times, most recently from 707dae6 to 2128066 Compare September 1, 2021 09:25
@Cherish-Gww
Copy link
Author

Cherish-Gww commented Sep 1, 2021

@hardbyte
I have add install libraries to package

    data_files=[
        ('can/interfaces/canalystii', ['can/interfaces/canalystii/libcontrolcan.so']),
        ('can/interfaces/canalystii', ['can/interfaces/canalystii/ControlCAN.dll'])
    ],

but when I use:

$ pip3.7 install git+https://github.com/Cherish-Gww/python-can.git@add_canalystii_so

it does not install libraries to my local sit-packages, it install to ~/.local.
How can I install dll and so file to my ~/.local/lib/pythonx.y/site-packages directory

@Cherish-Gww
Copy link
Author

@felixdivo @hardbyte
could help me?
I want package dll and so file to ~/.local/lib/pythonx.y/site-packages/can/interfaces/canalystii directory/

@felixdivo
Copy link
Collaborator

Generally speaking, adding the binary DLLs/SOs to this library is probably not wanted. I don't quite know what the problem with your install process is, but also, that's a problem you should better ask the folks that manage pip. They know their tools the best, I suppose.

@projectgus
Copy link
Contributor

projectgus commented Sep 9, 2021

This seems like probably a copyright issue adding the binary libs to this repo?

FWIW, I have a project and a python-can branch that removes the need for these binary libraries:

Plan to submit a PR soon, currently doing some final tests.

EDIT: PR is up #1127

@hardbyte hardbyte closed this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants