Specific Exceptions: Adapting cantact interface #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #1046. Also publicly exposes a new exception helper: `error_check` that was previously part of the `usb2can` interface.
21 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1153 +/- ##
===========================================
- Coverage 70.48% 70.46% -0.03%
===========================================
Files 79 79
Lines 7684 7688 +4
===========================================
+ Hits 5416 5417 +1
- Misses 2268 2271 +3 |
felixdivo
commented
Oct 27, 2021
| set_bit_timing = Mock() | ||
| set_enabled = Mock() | ||
| set_monitor = Mock() | ||
| start = Mock() |
Collaborator
Author
There was a problem hiding this comment.
This was duplicated
Collaborator
Author
|
This PR is important since I need the exception helper |
hardbyte
approved these changes
Nov 11, 2021
Comment on lines
+105
to
+117
| @contextmanager | ||
| def error_check( | ||
| error_message: Optional[str] = None, | ||
| exception_type: Type[CanError] = CanOperationError, | ||
| ) -> None: | ||
| """Catches any exceptions and turns them into the new type while preserving the stack trace.""" | ||
| try: | ||
| yield | ||
| except Exception as error: | ||
| if error_message is None: | ||
| raise exception_type(str(error)) from error | ||
| else: | ||
| raise exception_type(error_message) from error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1046.
Also publicly exposes a new exception helper
error_checkwhich was previously part of theusb2caninterface.