Specific Exceptions: Adapting systec interface #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1158 +/- ##
===========================================
- Coverage 70.53% 70.44% -0.10%
===========================================
Files 79 79
Lines 7684 7717 +33
===========================================
+ Hits 5420 5436 +16
- Misses 2264 2281 +17 |
21 tasks
Collaborator
Author
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
hardbyte
approved these changes
Nov 11, 2021
Comment on lines
+99
to
+101
| except CanError as error: | ||
| raise error | ||
| except Exception as exception: |
Owner
There was a problem hiding this comment.
That's a nice solution for allowing CanError exceptions to propagate
cowo78
pushed a commit
to cowo78/python-can
that referenced
this pull request
Dec 9, 2021
* Improve error handling with existing classes * Format code with black * Correct exception handling at startup * Throw the correct exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1046.