Complete broken PR #1156 (Specific Exceptions: Adapting slcan interface) #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1166 +/- ##
===========================================
+ Coverage 70.81% 71.28% +0.46%
===========================================
Files 79 79
Lines 7737 7867 +130
===========================================
+ Hits 5479 5608 +129
- Misses 2258 2259 +1 |
This was referenced Nov 11, 2021
Collaborator
Author
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebasedHey, I reacted but my real name is @Mergifyio |
hardbyte
force-pushed
the
felixdivo-issue-1046-slcan-fix
branch
from
0557d12 to
5227113
Compare
Contributor
☑️ Nothing to doDetails
|
hardbyte
approved these changes
Nov 16, 2021
…python-can into felixdivo-issue-1046-slcan-fix
Collaborator
Author
|
@hardbyte Thanks for your review. I also added a tiny test code fix for the recent failures of |
cowo78
pushed a commit
to cowo78/python-can
that referenced
this pull request
Dec 9, 2021
… interface) (hardbyte#1166) * Complete switch to new exceptions * Format code * Fix TestBaseRotatingLogger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am sorry, #1156 should not have been merged as some changes were still missing. This PR corrects that.