Skip to content

Conversation

@hardbyte
Copy link
Owner

@hardbyte hardbyte commented Feb 4, 2022

Closes #1242

@hardbyte hardbyte requested a review from felixdivo February 4, 2022 21:49
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #1251 (71193a9) into develop (257d57d) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1251      +/-   ##
===========================================
+ Coverage    65.89%   65.93%   +0.04%     
===========================================
  Files           86       86              
  Lines         8887     8887              
===========================================
+ Hits          5856     5860       +4     
+ Misses        3031     3027       -4     

@felixdivo felixdivo added this to the 4.0.0 Release milestone Feb 6, 2022
@felixdivo felixdivo added the docs label Feb 6, 2022
Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Removing emails sounds good. Some may be uncomfortable with plainly putting it online. And it might get out of date. It's probably best to @mention people in issues or use the mailing list anyways.

  2. Using the handles is fine to me, but everybody may add their real name though if they want!

  3. The history.rst looks great.

  4. CONTRIBUTING.md 👍

@hardbyte hardbyte merged commit 207be4b into develop Feb 7, 2022
@mergify mergify bot deleted the update-history branch February 7, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTERS.txt and history.rst

3 participants