Adding ICS CAN FD support #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixdivo
reviewed
Sep 6, 2018
felixdivo
approved these changes
Sep 6, 2018
Collaborator
|
Can you send CAN-FD frames too? |
Codecov Report
@@ Coverage Diff @@
## develop #408 +/- ##
===========================================
- Coverage 60.15% 59.89% -0.27%
===========================================
Files 54 54
Lines 4337 4356 +19
===========================================
Hits 2609 2609
- Misses 1728 1747 +19 |
Collaborator
Author
|
@christiansandberg yes sending is also supported. |
Collaborator
|
I don't get why Codecov complains here ... This line should allow the coverage to drop that much before failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.