Skip to content

Conversation

@felixdivo
Copy link
Collaborator

This basically removes all Pylint rules we were currently skipping that did not involve too much rewriting.

@felixdivo felixdivo added the QA about improving and maintaining the quality of the library label May 19, 2019
@felixdivo felixdivo added this to the 4.0 Release milestone May 19, 2019
@felixdivo felixdivo requested a review from karlding May 19, 2019 22:33
@felixdivo felixdivo self-assigned this May 19, 2019
@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #601 into develop will decrease coverage by 0.2%.
The diff coverage is 51.08%.

@@             Coverage Diff             @@
##           develop     #601      +/-   ##
===========================================
- Coverage    63.99%   63.79%   -0.21%     
===========================================
  Files           63       63              
  Lines         5572     5532      -40     
===========================================
- Hits          3566     3529      -37     
+ Misses        2006     2003       -3

@felixdivo
Copy link
Collaborator Author

felixdivo commented May 19, 2019

Ah shoot. I messed with the *args position. Let me fix that first. (Done)

@felixdivo felixdivo requested a review from hardbyte May 19, 2019 23:12
Repository owner deleted a comment from codecov bot May 19, 2019
@felixdivo
Copy link
Collaborator Author

The coverage went down since I deleted quite a lot of unused imports.

Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spring cleaning

@felixdivo felixdivo merged commit 5ab1e70 into develop May 20, 2019
@felixdivo felixdivo deleted the remove-some-linter-exclusions branch May 20, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA about improving and maintaining the quality of the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants