Skip to content

Conversation

@pierreluctg
Copy link
Collaborator

No description provided.

@pierreluctg pierreluctg requested a review from felixdivo May 23, 2019 14:16
@pierreluctg pierreluctg requested a review from hardbyte May 23, 2019 14:17
Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add some testing for FD if we add this. Like
(a) adding some example FD frames to logfile.asc and/or
(b) adding actual FD testing to logformat_test.py

Apart from that, it looks nice.

@felixdivo felixdivo added enhancement file-io about reading & writing to files labels May 23, 2019
@pierreluctg
Copy link
Collaborator Author

I will add proper tests as soon as possible...

@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #604 into develop will decrease coverage by 0.28%.
The diff coverage is 30%.

@@             Coverage Diff             @@
##           develop     #604      +/-   ##
===========================================
- Coverage       64%   63.72%   -0.29%     
===========================================
  Files           63       63              
  Lines         5607     5541      -66     
===========================================
- Hits          3589     3531      -58     
+ Misses        2018     2010       -8

@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #604 into develop will decrease coverage by 0.06%.
The diff coverage is 30%.

@@             Coverage Diff             @@
##           develop     #604      +/-   ##
===========================================
- Coverage    68.74%   68.67%   -0.07%     
===========================================
  Files           69       69              
  Lines         6245     6254       +9     
===========================================
+ Hits          4293     4295       +2     
- Misses        1952     1959       +7

@felixdivo
Copy link
Collaborator

I did a rebase but maybe some things need to be adjusted because the black formatter requires it.

@felixdivo felixdivo added this to the 4.0 Release milestone Jun 12, 2019
Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the formatting. Apart for some tests, this can be merged.

@felixdivo
Copy link
Collaborator

This could also resolve the old #269.

@christiansandberg
Copy link
Collaborator

I’m doing some refactoring of the blf module and in the meantime adding general CAN-FD testing capability.

@felixdivo felixdivo merged commit 3b68a54 into develop Sep 4, 2019
@felixdivo felixdivo deleted the asc-writer-canfd branch September 4, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement file-io about reading & writing to files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants