-
Notifications
You must be signed in to change notification settings - Fork 659
Adding CAN FD frame support to asc writer #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
felixdivo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add some testing for FD if we add this. Like
(a) adding some example FD frames to logfile.asc and/or
(b) adding actual FD testing to logformat_test.py
Apart from that, it looks nice.
|
I will add proper tests as soon as possible... |
Codecov Report
@@ Coverage Diff @@
## develop #604 +/- ##
===========================================
- Coverage 64% 63.72% -0.29%
===========================================
Files 63 63
Lines 5607 5541 -66
===========================================
- Hits 3589 3531 -58
+ Misses 2018 2010 -8 |
Codecov Report
@@ Coverage Diff @@
## develop #604 +/- ##
===========================================
- Coverage 68.74% 68.67% -0.07%
===========================================
Files 69 69
Lines 6245 6254 +9
===========================================
+ Hits 4293 4295 +2
- Misses 1952 1959 +7 |
|
I did a rebase but maybe some things need to be adjusted because the black formatter requires it. |
felixdivo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the formatting. Apart for some tests, this can be merged.
|
This could also resolve the old #269. |
|
I’m doing some refactoring of the blf module and in the meantime adding general CAN-FD testing capability. |
No description provided.