Fix iteration in Bus.stop_all_periodic_tasks #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying a list while iterating over it results in unspecified order. This is now fixed in `Bus.stop_all_periodic_tasks`. What happens when an exception is thrown while stopping a task? Do we want to catch it, log it and continue? Or do we want to leave the note on unspecified behaviour in there? Fixes #634
hardbyte
approved these changes
Jul 11, 2019
Codecov Report
@@ Coverage Diff @@
## develop #637 +/- ##
===========================================
- Coverage 63.89% 63.88% -0.01%
===========================================
Files 66 66
Lines 5955 5948 -7
===========================================
- Hits 3805 3800 -5
+ Misses 2150 2148 -2 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #637 +/- ##
===========================================
- Coverage 63.89% 63.88% -0.01%
===========================================
Files 66 66
Lines 5955 5948 -7
===========================================
- Hits 3805 3800 -5
+ Misses 2150 2148 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying a list while iterating over it results in unspecified order. This is now fixed in
Bus.stop_all_periodic_tasks.What happens when an exception is thrown while stopping a task? Do we want to catch it, log it and continue? Or do we want to leave the note on unspecified behaviour in there?
Fixes #634