Skip to content

PCAN: add support for detecting available channels #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixdivo merged 7 commits into from
Jul 18, 2019
Merged

PCAN: add support for detecting available channels #640

felixdivo merged 7 commits into from
Jul 18, 2019

Conversation

@jsee23
Copy link
Contributor

@jsee23 jsee23 commented Jul 14, 2019

No description provided.

@jsee23 jsee23 changed the title PPCAN: add support for detecting available channels PCAN: add support for detecting available channels Jul 14, 2019
@jsee23 jsee23 mentioned this pull request Jul 14, 2019
Merged
@felixdivo
Copy link
Collaborator

felixdivo commented Jul 15, 2019

Thank you for improving this! It seems like some tests do net yet work, any the formatter will probably spit out some improvements as well. Generally, the channels variable can be defined right above the for loop.

felixdivo
felixdivo reviewed Jul 15, 2019
View reviewed changes
@jsee23 @felixdivo
use consistent naming scheme
2868b66 
Co-Authored-By: Felix Divo <felixdivo@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 15, 2019 •
edited
Loading

Codecov Report

Merging #640 into develop will decrease coverage by 0.08%.
The diff coverage is 24%.

@@             Coverage Diff             @@
##           develop     #640      +/-   ##
===========================================
- Coverage    63.54%   63.46%   -0.09%     
===========================================
  Files           66       66              
  Lines         5991     6016      +25     
===========================================
+ Hits          3807     3818      +11     
- Misses        2184     2198      +14

@jsee23
Copy link
Contributor Author

jsee23 commented Jul 15, 2019

Thanks for your feedback, I will check the tests by this evening.

Repository owner deleted a comment from codecov bot Jul 18, 2019
@felixdivo felixdivo mentioned this pull request Jul 18, 2019
Closed
14 tasks
@felixdivo felixdivo merged commit 12eae4d into hardbyte:develop Jul 18, 2019
@felixdivo felixdivo added this to the 4.0 Release milestone Jul 18, 2019
@jsee23 jsee23 deleted the pcan-config-query branch September 13, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixdivo felixdivo felixdivo approved these changes

Assignees

@jsee23 jsee23

Labels

api backend:pcan

Projects

None yet

Milestone

4.0.0 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@jsee23 @felixdivo