-
Notifications
You must be signed in to change notification settings - Fork 659
Add support for base 10 in CANReader #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: I61a04c53276ea5b74e81d77267ef5e063a211d8a
felixdivo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @multiplor for you contribution!
This generally looks good, although I do not unterstand the benefit of a specific parser exception against for example a simple ValueError. What was the rationale?
|
And both linter and formatter complain, you can run them locally with |
can/io/asc.py
Outdated
| self.base = BASES[base] | ||
| self.absolute_timestamps = m.group('timestamps') == 'absolute' | ||
| break | ||
| self.file.seek(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really necessary to seek? Couldn’t we just parse the header until we hit Begin Triggerblock and then continue with the actual log entries? The reason I’m asking is because there might be cases where one would like to stream the log over e.g. HTTP or something and then it would not be possible to seek.
Codecov Report
@@ Coverage Diff @@
## develop #685 +/- ##
===========================================
+ Coverage 68.74% 68.81% +0.07%
===========================================
Files 69 69
Lines 6245 6253 +8
===========================================
+ Hits 4293 4303 +10
+ Misses 1952 1950 -2 |
Codecov Report
@@ Coverage Diff @@
## develop #685 +/- ##
===========================================
- Coverage 68.74% 64.68% -4.06%
===========================================
Files 69 69
Lines 6245 6153 -92
===========================================
- Hits 4293 3980 -313
- Misses 1952 2173 +221 |
Change-Id: I31169574892448f5df52da21fe563272244d8634
|
I think this is superseded by #820. |
Change-Id: I61a04c53276ea5b74e81d77267ef5e063a211d8a