-
Notifications
You must be signed in to change notification settings - Fork 659
Changes to add direction to CAN messages #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #773 +/- ##
===========================================
- Coverage 69.48% 67.01% -2.47%
===========================================
Files 70 70
Lines 6525 6522 -3
===========================================
- Hits 4534 4371 -163
- Misses 1991 2151 +160 |
|
Thanks for your contribution. I’ve been thinking that this would be a nice feature. There are some more places in the Message class where this needs to be added as well. And the documentation should be updated. |
|
Added documentation and copy/deepcopy changes for message class @christiansandberg Let me know if any more changes are needed. I deliberately left out checking Rx/Tx in the equals method for now. |
|
You can also add it to repr(). We have been discussing a lot of what constitutes two equal messages. In the end we decided the default should be to check all attributes because that leads to less surprises. In some cases it is however possible to relax this by providing arguments to equals() and that seems appropriate for this since you might want to consider self reception of a sent message as being identical. |
Adds direction to can.Message with the bool attribute is_rx
Adds corresponding changes to ASC & BLF io