Skip to content

Conversation

@sou1hacker
Copy link
Contributor

Adds direction to can.Message with the bool attribute is_rx
Adds corresponding changes to ASC & BLF io

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #773 into develop will decrease coverage by 2.46%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #773      +/-   ##
===========================================
- Coverage    69.48%   67.01%   -2.47%     
===========================================
  Files           70       70              
  Lines         6525     6522       -3     
===========================================
- Hits          4534     4371     -163     
- Misses        1991     2151     +160     

@sou1hacker sou1hacker marked this pull request as ready for review February 20, 2020 21:13
@christiansandberg
Copy link
Collaborator

Thanks for your contribution. I’ve been thinking that this would be a nice feature. There are some more places in the Message class where this needs to be added as well. And the documentation should be updated.

@sou1hacker
Copy link
Contributor Author

Added documentation and copy/deepcopy changes for message class

@christiansandberg Let me know if any more changes are needed. I deliberately left out checking Rx/Tx in the equals method for now.

@christiansandberg
Copy link
Collaborator

You can also add it to repr().

We have been discussing a lot of what constitutes two equal messages. In the end we decided the default should be to check all attributes because that leads to less surprises. In some cases it is however possible to relax this by providing arguments to equals() and that seems appropriate for this since you might want to consider self reception of a sent message as being identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants