add vector hardware config popup #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from upstream
Codecov Report
@@ Coverage Diff @@
## develop #774 +/- ##
===========================================
- Coverage 69.53% 69.48% -0.05%
===========================================
Files 70 70
Lines 6548 6557 +9
===========================================
+ Hits 4553 4556 +3
- Misses 1995 2001 +6 |
christiansandberg
requested changes
Feb 21, 2020
can/interfaces/vector/canlib.py
Outdated
| """Open vector hardware configuration window. | ||
| :param int wait_for_finish: | ||
| Time to wait for user input. |
Collaborator
There was a problem hiding this comment.
Specify that it should be in milliseconds.
christiansandberg
approved these changes
Feb 21, 2020
Collaborator
Author
|
@christiansandberg Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.