Adding plugin support to can.io Reader/Writer #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #783 +/- ##
===========================================
+ Coverage 69.48% 69.52% +0.04%
===========================================
Files 70 70
Lines 6535 6544 +9
===========================================
+ Hits 4541 4550 +9
Misses 1994 1994 |
pierreluctg
requested review from
christiansandberg,
felixdivo and
pierreluctg
pierreluctg
approved these changes
Feb 29, 2020
zariiii9003
reviewed
Nov 13, 2022
| if not Logger.fetched_plugins: | ||
| Logger.message_writers.update( | ||
| { | ||
| writer.name: writer.load() |
Collaborator
There was a problem hiding this comment.
@felixdivo @sou1hacker
This is quite old, but is this load method actually documented anywhere?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to plug in their own reader/writer implementation to can.io functions. Similar to how we have plugin support for can interfaces (BACKENDS)