Skip to content

Add _detect_available_configs to serial_can #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixdivo merged 2 commits into from
Apr 29, 2020
Merged

Add _detect_available_configs to serial_can #811

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d04335
Add _detect_available_configs to serial_can
josko7452 Apr 17, 2020
8fb8f50
Merge branch 'develop' into detect-available-configs-serial
felixdivo Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions can/interfaces/serial/serial_can.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@
)
serial = None

try:
from serial.tools import list_ports
except ImportError:
list_ports = None


class SerialBus(BusABC):
"""
Expand Down Expand Up @@ -162,3 +167,15 @@ def fileno(self):
return self.ser.fileno()
# Return an invalid file descriptor on Windows
return -1

@staticmethod
def _detect_available_configs():
channels = []
serial_ports = []

if list_ports:
serial_ports = list_ports.comports()

for port in serial_ports:
channels.append({"interface": "serial", "channel": port.device})
return channels