Raising more precise API error when set bitrate fails #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreluctg
requested review from
christiansandberg,
felixdivo,
hardbyte and
karlding
felixdivo
approved these changes
Jul 9, 2020
Also calling shutdown before raising exception from the init if the device is opened
pierreluctg
force-pushed
the
neovi-set-bitrate-error
branch
from
17aad06 to
436e78f
Compare
hardbyte
approved these changes
Jul 10, 2020
karlding
approved these changes
Jul 10, 2020
Collaborator
Author
|
@hardbyte can you please merge. The |
Collaborator
|
They randomly worked when I restarted them a minute ago. |
Codecov Report
@@ Coverage Diff @@
## develop #865 +/- ##
===========================================
- Coverage 70.44% 70.38% -0.07%
===========================================
Files 70 70
Lines 6835 6841 +6
===========================================
Hits 4815 4815
- Misses 2020 2026 +6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also calling shutdown before raising exception from the init if the device is opened