vector: Skip channels without CAN support #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip any channels that don't have support for CAN (ex. LIN, Digital/Analog IO) instead of accepting everything when using auto-detection. Note: This is a backport of hardbyte#641 to 3.3.4 Addresses hardbyte#908
Codecov Report
@@ Coverage Diff @@
## release-3.3.4 #916 +/- ##
=================================================
- Coverage 65.90% 65.85% -0.05%
=================================================
Files 63 63
Lines 5848 5852 +4
=================================================
Hits 3854 3854
- Misses 1994 1998 +4 |
christiansandberg
approved these changes
Oct 1, 2020
zariiii9003
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip any channels that don't have support for CAN (ex. LIN,
Digital/Analog IO) instead of accepting everything when using
auto-detection.
Note: This is a backport of #641 to 3.3.4
Addresses #908