Fix buffer overflow for arity > 16 in Nary ops#19
Open
a2435191 wants to merge 2 commits into
Open
Conversation
a2435191
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently, an n-ary operation with n > 16 overflows a buffer.
Changes Made
I updated the compiler with an assert in the constructor of
NaryOpand a graceful compiler error in the one place where the arity isn't known. Since it seems bad to just trust the HVM output, I also added a check ininit_Naryinops.c, where the JSON data is loaded, and finally an assert right before the place where the buffer overflow actually happened inop_Nary.Crash log
Test Coverage
I tested the changes by selectively disabling some checks. I wasn't able to test the
assertthough.Next Steps
Maybe the compiler could automatically split up ops with arity > 16.