FFM-11654 Sort serving rules in cache code#192
Merged
erdirowlands merged 1 commit intomainfrom Jun 28, 2024
Merged
Conversation
akiraqb
approved these changes
Jun 28, 2024
Contributor
akiraqb
left a comment
akiraqb
left a comment
There was a problem hiding this comment.
Chatted to Erdi, looks apart form the apikey
Contributor
Author
thanks - removed and history wiped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AND/ORrules outside of the critical evaluation path into the point we save them to the cache.Why
Avoid the cost of sorting multiple times during evaluations when it is unnecessary, which can add evaluation latency.
Testing
TestGrid - both old style and new style scenarios pass.