[FFM-11856]: Store and retrieve previous and current version of the feature config from the fileStore.#195
Merged
Conversation
|
|
added 2 commits
August 7, 2024 16:16
erdirowlands
reviewed
Aug 7, 2024
| final String previousFlagKey = formatPrevFlagKey(identifier); | ||
| if (store != null) { | ||
| store.set(previousFlagKey, previousFeatureConfig); | ||
| cache.delete(previousFlagKey); |
Contributor
There was a problem hiding this comment.
question: When store is present, do we also need to delete the current flag key from the cache?
Contributor
Author
There was a problem hiding this comment.
apparently so - i did not find any documentation about that but the log statement in the previous version of the code says - stored and cache invalidated.
erdirowlands
approved these changes
Aug 7, 2024
Contributor
erdirowlands
left a comment
erdirowlands
left a comment
There was a problem hiding this comment.
This looks good! again just a small query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.