Conversation
|
|
| public FeatureConfig GetFeatureConfigFromFile() throws Exception { | ||
| try { | ||
| String relativePath = | ||
| "./src/test/resources/local-test-cases/basic_bool_string_for_repository.json"; |
There was a problem hiding this comment.
Does this file already exist ?
| FeatureConfig pFlag = (FeatureConfig) cache.get(pFlagKey); | ||
| FeatureConfig cFlag = (FeatureConfig) cache.get(flagKey); | ||
|
|
||
| if (cFlag != null) { |
There was a problem hiding this comment.
should there be a null check for pFlag as well here? I'm assuming there is an assumption that if we dont have the current then we wont have the previous.
There was a problem hiding this comment.
if the previous flag does not exist we still want to package that to the snapshot even if its null.
davejohnston
left a comment
davejohnston
left a comment
There was a problem hiding this comment.
This looks good, a minor comment just to check, but if youre happy go for it.
3 participants
No description provided.