Add schema proposal #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artursilva0
requested changes
Jul 25, 2023
device.yml
Outdated
| type: U8 | ||
| maskType: LedState | ||
| description: Enables the stimulation LEDs. | ||
| description: Continuously enables/disables the LEDs. |
Contributor
There was a problem hiding this comment.
Humm, I understand why you've changed this, but continuously as it is might be misleading (it seems that is toggling between enable and disable). What about "Enables/disables the LEDs (continuously on/continuously off)."
Member
Author
There was a problem hiding this comment.
I thought it was important to give users the hint that this register just straight-up turns leds on and off, and not some other pre-programmed behavior. I might have been overzealous :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.