-
Notifications
You must be signed in to change notification settings - Fork 4
v3.0 firmware release #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is needed to keep the firmware update working.
bruno-f-cruz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a common typo across many firmware files that would be nice to fix
Bug correction fw clean registers
glopesdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise looks good. The PR is still marked as draft, I guess one important thing we need to discuss before broad deployment is how to deal with firmware updates in cases of multi-microcontroller devices.
Would be nice if it is possible to have a uniform update procedure using the existing bootloader protocol, but maybe let us discuss this in a separate issue / PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the device.yml and have some questions / suggestions that would be nice to review together. It might impact firmware naming a little bit, but hopefully not too hard to replace.
|
@filcarv @artursilva0 @bruno-f-cruz A reminder that another thing we need to do before merging is regenerate the interface. We might end up merging #24 first so we are able to check this automatically for every PR from now on. P.S.: We also probably want to rebase this branch first so we make sure to use the latest version of the generators. |
Uh oh!
There was an error while loading. Please reload this page.