Skip to content

Allow indexing of registers by register number #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
glopesdev merged 17 commits into from
Dec 17, 2023
Merged

Allow indexing of registers by register number #22

glopesdev merged 17 commits into from
Dec 17, 2023

Conversation

@bruno-f-cruz
Copy link
Member

@bruno-f-cruz bruno-f-cruz commented Dec 11, 2023

Allow indexing of registers by register number
Closes #21

@bruno-f-cruz
Copy link
Member Author

bruno-f-cruz commented Dec 11, 2023

Should consider moving the polymorphic behavior to the register property directly instead of overloading the index operator on the Device class.

glopesdev
glopesdev reviewed Dec 11, 2023
View reviewed changes
glopesdev
glopesdev requested changes Dec 15, 2023
View reviewed changes
glopesdev
glopesdev requested changes Dec 16, 2023
View reviewed changes
glopesdev
glopesdev requested changes Dec 16, 2023
View reviewed changes
glopesdev
glopesdev requested changes Dec 16, 2023
View reviewed changes
@glopesdev glopesdev merged commit ebd12ce into main Dec 17, 2023
@glopesdev glopesdev deleted the bc-dev branch December 17, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glopesdev glopesdev glopesdev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DeviceReader registers property should be indexable by register number

3 participants

@bruno-f-cruz @glopesdev