Skip to content

Avoid silent overflow for numpy compatibility #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glopesdev merged 2 commits into from
Oct 29, 2024
Merged

Avoid silent overflow for numpy compatibility #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f684ed3
Avoid silent overflow for numpy compatibility
glopesdev Oct 22, 2024
750bb53
Ensure stride uses default int type
glopesdev Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions harp/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def read(
raise ValueError(f"expected address {address} but got {data[2]}")

index = None
stride = data[1] + 2
stride = int(data[1] + 2)
nrows = len(data) // stride
payloadtype = data[4]
payloadoffset = 5
Expand All @@ -90,7 +90,7 @@ def read(
micros = np.ndarray(nrows, dtype=np.uint16, buffer=data, offset=payloadoffset, strides=stride)
payloadoffset += 2
time = micros * _SECONDS_PER_TICK + seconds
payloadtype = payloadtype & ~0x10
payloadtype = payloadtype & ~np.uint8(0x10)
if epoch is not None:
time = epoch + pd.to_timedelta(time, "s") # type: ignore
index = pd.Series(time)
Expand Down