-
Notifications
You must be signed in to change notification settings - Fork 6
Move all messaging patterns to device specification #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all messaging patterns to device specification #194
Conversation
77a5e9c to
a87d3f6
Compare
|
@bruno-f-cruz We could probably also resolve #55 in this PR. Leaving it here for discussion. |
If the goal of "mute replies" is to stop any feedback from a command from the device, then I still think that suppressing the error response falls within this category. |
Just to clarify, I'm assuming you mean here to set the flag. I'm fine with any interpretation, but I would be interested in hearing from @filcarv and @Poofjunior what exactly is implemented in core.atxmega and core.pico and whether both match this (and each other). If not, we need to decide what to change to make things consistent. |
b07ec13 to
3e5b7f2
Compare
@bruno-f-cruz Indeed, I just tested this and at least on the ATXmega core, the error responses are indeed suppressed if the Interestingly, this also suppresses the reply to the |
In the near-future we may want to use this as an explicit exception throwing mechanism used by the Parse operator.
3e5b7f2 to
2d4af89
Compare
To further clarify and separate the specification of device operation from the binary protocol, we move all messaging patterns to Device.md. This greatly reduces the number of cross-references and duplicate terminology across both documents.
2d4af89 to
36f7abf
Compare
dc26e30 to
09c1c88
Compare
Specifically, we want to clarify the payload should send the register contents after the request is processed.
55cc9fc to
0951e74
Compare
As described in #71, error handling is a growing concern for consistent implementation of Harp device interfaces.
Remove ambiguous versioning string
This version string was already ambiguous and will be superseded altogether by tags in this repository.
Move error handling to messaging patterns section
The new sub-section aims to provide clearer guidelines on how various kinds of errors should be handled and reported.
Clarify rejection of register writes
Account for possibility to flag events as errors
In the near-future we may want to use this as an explicit exception
throwing mechanism used by the Parse operator.
Clarify error handling recommendations
Move messaging patterns to device specification
To further clarify and separate the specification of device operation
from the binary protocol, we move all messaging patterns to Device.md.
This greatly reduces the number of cross-references and duplicate
terminology across both documents.
Closes #71
Closes #55