Displaying trigger jobs in pipeline popup has broken showing pipeline logs

[jakubbortlik]

Prerequsities

• I'm on the latest develop version of the plugin
• I've installed the required dependencies
• I've run :h gitlab.nvim.troubleshooting and followed the steps there

Bug Description

The see logs function as the "linewise action" in the pipeline popup is broken since #465.

@ashish10alex do you think you could try and fix it?

[ashish10alex]

Hi @jakubbortlik , thanks for raising the issue. I have not use this functionality. Could you please let me know how to invoke the see logs and also if you could add the screenshot of expected output in main branch and output in dev branch. I might be able to narrow down on the fix for the issue.

[jakubbortlik]

Hi @ashish10alex, the see_logs function is executed with the perform_linewise_action keybinding which is ZA by default. It opens a new tab and shows a temporary buffer with the job log.

The see_logs function expects M.pipeline_jobs to be a table of jobs. In your MR, you made this a local variable. Maybe it can be fixed by just adding the local pipeline_jobs to the global table.

If you need more info let me know.

[jakubbortlik]

Yeah, I've been able to make it work again with simply:

diff --git a/lua/gitlab/actions/pipeline.lua b/lua/gitlab/actions/pipeline.lua
index bc113c2..e3ce745 100644
--- a/lua/gitlab/actions/pipeline.lua
+++ b/lua/gitlab/actions/pipeline.lua
@@ -7,7 +7,7 @@ local job = require("gitlab.job")
 local u = require("gitlab.utils")
 local popup = require("gitlab.popup")
 local M = {
-  pipeline_jobs = nil,
+  pipeline_jobs = {},
   latest_pipeline = nil,
   pipeline_popup = nil,
 }
@@ -57,6 +57,9 @@ M.open = function()
     local width = string.len(pipeline.web_url) + 10
     max_width = math.max(max_width, width)
     local pipeline_jobs = get_pipeline_jobs(idx)
+    for _, j in ipairs(pipeline_jobs) do
+      table.insert(M.pipeline_jobs, j)
+    end
     local pipeline_status = M.get_pipeline_status(idx, false)
     local height = 6 + #pipeline_jobs + 3
     total_height = total_height + height

But maybe some more testing is required.

[ashish10alex]

Hi @jakubbortlik , I tested locally and it works correctly with change your change you suggested. Would you like me to create an MR or would you like to do it ? . Thanks again for spotting it 🙂

[jakubbortlik]

Could you please verify that the other perform_action (retriggering the job under cursor) is working with the fix? And then open a PR?

I think that the UX of the see_logs could be improved by switching to the newly created tab, what do you think? Could you maybe add that functionality to the callback? I believe something as simple as a vim.cmd.tabnext() would do the trick.

[ashish10alex]

@jakubbortlik , I have created the MR. The re-triggering of pipeline was broken too. However, I doubt how could it work in main as the request route for re-trigger does not match in pipeline.lua and pipeline.go. More details the MR.

see_logs could be improved by switching to the newly created tab

This already seems to be default behaviour when I tried it

[harrisoncramer]

Your PR has been merged into main, if this is not fixed please let me know and I'll reopen this issue.