Fix: Iterate over several pages to get all discussions#183
Closed
jakubbortlik wants to merge 2 commits intoharrisoncramer:mainfrom
Closed
Fix: Iterate over several pages to get all discussions#183jakubbortlik wants to merge 2 commits intoharrisoncramer:mainfrom
jakubbortlik wants to merge 2 commits intoharrisoncramer:mainfrom
Conversation
Collaborator
Author
|
After some trial and error I've made the tests pass, but I'm not sure the test are now the way you want them. |
3 tasks
This is a very naive fix due to my poor knowledge of Go.
jakubbortlik
force-pushed
the
fix-exceeded-maximum-number-of-items-per-page
branch
from
a4f264a to
a07aed4
Compare
Collaborator
Author
|
Closing, as the simple suggested solution conflicts with the newly added code for emojis and there'll certainly be a better way to fix the problem with unlisted discussions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a naive fix for #182. I've just added a loop that goes over several pages of discussions to get more items than the default 100 allowed by Gitlab.
gitlab.nvimtries to get 250, but cannot get more than 100 in one request.