Skip to content
This repository was archived by the owner on May 16, 2020. It is now read-only.

Issue 168#176

Open
kracekumar wants to merge 14 commits intomasterfrom
issue-168
Open

Issue 168#176
kracekumar wants to merge 14 commits intomasterfrom
issue-168

Conversation

@kracekumar
Copy link
Copy Markdown
Contributor

@kracekumar kracekumar commented Apr 25, 2013

Fixes issue #168 .

  • New projects cannot be created when hacknight is closed but comments and editing the description of the projects are allowed.

jace
jace reviewed Apr 25, 2013
View reviewed changes
Comment thread hacknight/views/event.py Outdated
Copy link
Copy Markdown
Member

@jace jace Apr 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Krace, you need to use workflow actions. The workflow object can automatically generate a list of available actions for the current state. See Kharcha for an example of how to do this.

Copy link
Copy Markdown
Member

@jace jace Apr 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, these choices should NOT be in the Edit form. They should be actions from the sidebar on the event page.

Copy link
Copy Markdown
Contributor Author

@kracekumar kracekumar Apr 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@jace
Copy link
Copy Markdown
Member

jace commented Apr 27, 2013

Krace, this pull request needs to be rebased.

@jace
Copy link
Copy Markdown
Member

jace commented May 18, 2013

Can you update this pull request to prepare for merging?

jace
jace reviewed May 19, 2013
View reviewed changes
Comment thread hacknight/forms/event.py Outdated
Copy link
Copy Markdown
Member

@jace jace May 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this flag also to PUBLIC (here and with all references).

Copy link
Copy Markdown
Contributor Author

@kracekumar kracekumar May 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change public to PUBLIC or active to PUBLIC ? Should we capitalise ?

Copy link
Copy Markdown
Contributor Author

@kracekumar kracekumar May 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh got it, EVENT_STATUS.PUBLIC

@kracekumar kracekumar mentioned this pull request May 27, 2013
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kracekumar @jace