Skip to content

Minor fixes to work on multiple platforms #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fgiorgetti wants to merge 65 commits into
base: dh-policy-testing-2
Choose a base branch
from
Open

Minor fixes to work on multiple platforms #1

fgiorgetti wants to merge 65 commits into from

Conversation

@fgiorgetti
Copy link

@fgiorgetti fgiorgetti commented May 13, 2022

No description provided.

hash-d added 30 commits May 12, 2022 10:53
@hash-d
Policy testing
9f3ade6
@hash-d
Initial label testing and env-var test directives
512fcb3 
Includes rebase conflict fix from
1439e44

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Additional namespace testing and suspend container failure check
39f7d2d 
The container failure check is new, and it is failing because sometimes
the container will successfully come up and then successfully restart,
and that should be expected, but the check thinks it went down.

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Implemented namespace and crd setup skipping
13fee24 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Restructured the test to move the setup/teardown to main
635d8ae 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
More refactoring
492096d 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Added note on policy reading permissions affecting policy enablement
112f999 
That's a recent change to how the policies work

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Refactor hello_policy to use shared namespace
7b7c8aa 
Also added testLinkPolicy (only a shell) and other refactoring
to reuse code

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Refactor to make individual test selection possible
16e21e8 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
More code reuse, and paralellized init/delete
3367b7d 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Started actual link tests; fixed parallel run
d4c69c4 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Ensured as much of hello policy worked as possible
c44dcfa 
The site-controller image is still not fixed to allow linke
re creation on CRD removal

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Updates following the review of the March/18 meeting
27f194c
@hash-d
Minor updates on the previous commit
5f8c5cc 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Initial refactoring
d76d5b4 
- moving stuff to their proper places
- renaming to make more explicit

Committing early so I can rebase with the latest code

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
More refactoring and renaming
0028895 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Start of refactor for table-based
10c680f 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
More refactoring, towards an 'universal' policy test case
831a90d
@hash-d
test adds, infra improvements
f85b37b 
- add GetCheck to policyTestSetup
- updated existing tests to use GetCheck
- added test case 'previously-created-token'
- improved test interruption handling

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
First 'full' version of link testing, with accompanying infra changes
9baf5ee 
It's not working, but I'm guessing due to upstream image changes.

I'll rebase and investigate

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Added Gherkin file specific for Links
f7391b3 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Continued test and made allowIncomingLinkPolicy accept bool
b7579de 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Bypassed error on allowing-policy-allows-creation/link-is-down
742cbaf 
And other minor, unrelated changes

I'll probably enter an issue for that error, but I have a workaround
@hash-d
Fixed test bug on checking links on pub, and added sitesConnectedTest…
8d1a481 
…Scenario

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Assorted updates to the documentation
62f6cc2 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Made some stuff parallel; added todo for the same on others
4e62d65 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Documentation, refactoring, small enhancements
728292a 
Mostly moving stuff around

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
More refactoring.
4dcf3d1 
Most importantly, init and clean become normal PolicyTestCase entries,
instead of special parts of the code.  This allows the runner to be
properly reusable.

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
More refactoring: now we have a proper runner
250a458 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Added testNamespaceLinkTransitions
a657440 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
hash-d and others added 21 commits May 12, 2022 10:53
@hash-d
Service binding testing
21d660f 
- defined it on the features file
- defined service.StatusTester.unauthInterfaces, and implementation for
  it
- adapted tests for failing service-creation-after-policy-allowing
- created the actual first tests for binding

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Added base.PostPolicyChangeSleep and accompanying env var
191e0db 
Also, reorganized env file and identified 'sections'

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Implemented service bind test "show-on-both"
cfd115a 
And accompanying changes

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Added 'policy' build constraint to all hello_world files
69eac5d 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Marked older hello_policy test for skip.
0b43720 
This code will be removed before merging into main

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Remove CRD at start of test, to make it more predictable
a76b050 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
A few more tests for service binding
6cd30da 
With infra changes

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Added base.IsMaxStatusAttemptsReached for serviceCreateTester
15e8ffc 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Changes to make the tests more robust, mostly by ensuring policy remo…
1d2c529 
…vals

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Added re-add--re-create--not-bound to finish services for now
519e1ab 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Initial changes to check GET before and as req for cli runs
a8cef2e 
Used testNamespace test that was failing due to recent policy code
changes making the policy CR changes take a bit longer to reflect on the
clusters.  Also took the time to complete that test further.

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Finished moving GET checks to before CLI step
8ec5206 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Initial for hostname testing. Adds 'register' to runner
3719e22 
along with its contextMap

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Added missing build constraint
e6550f4 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Removed unnecessary pointer to map
f24cd4c 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Refactored register into preHook, and started work on hostnamesPolicy…
072c3e7 
…Instructions

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Moved map keys to constants, to avoid typos
8e755e9 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Simplified hostnamesPolicyInstructions.transformation
4ab498e 
It's now just a function to change a string into another; the actual
intelligence is on the preHook closure of the testcase

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
First real set of test cases for hostnames. Changes link.CreateTester
ff042bc 
Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@hash-d
Added status testing on hostnames (link goes up and down), but shelve…
7bf7767 
…d for now

The test is failing, probably because of a bug in skupper.  I'll keep
only the create tester for today at least, to avoid unnecessary warnings
on the CI

Signed-off-by: Danilo Gonzalez Hashimoto <dhashimo@redhat.com>
@fgiorgetti
Minor fixes to work on multiple platforms
195a9a5
@hash-d hash-d force-pushed the dh-policy-testing-2 branch 2 times, most recently from f4d4173 to 0d19413 Compare May 19, 2022 18:27
@hash-d hash-d force-pushed the dh-policy-testing-2 branch 2 times, most recently from bee091a to 00b6854 Compare June 3, 2022 12:50
@hash-d hash-d force-pushed the dh-policy-testing-2 branch from 11d3237 to 0cef60e Compare June 7, 2022 20:10
hash-d
hash-d reviewed Jun 13, 2022
View reviewed changes
Copy link
Owner

@hash-d hash-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed all suggestions, some in ways that differ from this PR. Individual comments added for each of them.

I'll not merge this PR, as it would require rebase, and, as mentioned, all suggestions have already been addressed

test/integration/acceptance/custom/hello_policy/init_test.go
EnableConsole: false,
EnableRouterConsole: false,
// ConsoleIngress: "none",
},
Copy link
Owner

@hash-d hash-d Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have kept the original configuration, as I want to keep as close as possible to the original hello world test.

test/integration/acceptance/custom/hello_policy/main_test.go
if _, err := cluster.KubectlExec("delete crd skupperclusterpolicies.skupper.io"); err != nil {
t.Fatalf("Removal of CRD failed: %v", err)
t.Logf("WARNING: Removal of CRD failed: %v", err)
}
Copy link
Owner

@hash-d hash-d Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been done as above in the PR

test/integration/acceptance/custom/hello_policy/main_test.go
if !base.MultipleClusters() {
break
}
}
Copy link
Owner

@hash-d hash-d Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more complex Multi-cluster setup has been created; each test can declare whether it works or not on a multi-cluster environment, and the secondary cluster will be configured for those tests that do.

test/integration/acceptance/custom/hello_policy/token_test.go
func createTokenPolicyScenario(cluster *base.ClusterContext, prefix, testPath, name string, works bool) (createToken cli.TestScenario) {

_ = os.MkdirAll(testPath, 0755)
createToken = cli.TestScenario{
Copy link
Owner

@hash-d hash-d Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has actually been done on the main test, as the tmp directory is used for tokens on more than one test function, and also for debug dumps

@hash-d hash-d force-pushed the dh-policy-testing-2 branch from e7b1427 to c71812d Compare June 14, 2022 18:32
@hash-d hash-d force-pushed the dh-policy-testing-2 branch 2 times, most recently from 66648e6 to 558116f Compare July 2, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hash-d hash-d hash-d left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fgiorgetti @hash-d