Skip to content

Conversation

@certik
Copy link
Member

@certik certik commented May 15, 2015

This fixes a build failure on OS X 10.10. Unfortunately, this disabled https
access, so it is only enabled if 'disable_crypto' parameter is 'true'.

This fixes a build failure on OS X 10.10. Unfortunately, this disabled https
access, so it is only enabled if 'disable_crypto' parameter is 'true'.
@certik
Copy link
Member Author

certik commented May 15, 2015

I should note that git builds fine with the native clang, but fails with gcc. So a profile with clang doesn't need any parameter, but a profile with gcc requires disable_crypto: true. But since it disables the https access, it's not an ideal solution at all, rather a workaround to get git build at all. We need to find a better solution for this.

This was referenced May 15, 2015
@jcftang
Copy link
Member

jcftang commented May 16, 2015

+1

@certik
Copy link
Member Author

certik commented May 16, 2015

Thanks. By default it doesn't do anything, and it optionally allows to make git build on OS X with gcc, albeit not ideally. We can improve upon this later.

certik added a commit that referenced this pull request May 16, 2015
git: allow to set NO_APPLE_COMMON_CRYPTO=1
@certik certik merged commit 9ce0f13 into master May 16, 2015
@certik certik deleted the git_apple_ssl_fix branch May 16, 2015 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants