Add "pins" as a grant segment#6683
Open
jefferai wants to merge 7 commits into
Open
Conversation
irenarindos
reviewed
May 7, 2026
irenarindos
reviewed
May 7, 2026
irenarindos
reviewed
May 7, 2026
Co-authored-by: Irena Rindos <irenarindos@users.noreply.github.com>
irenarindos
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ability to pin grants to a specific collection has been supported for a long time, but the syntax is confusing. It reuses
ids(originallyid) with the thinking that you are granting, e.g.,readonhost setswithin the collection with idfoobar. Or, from another standpoint, infoobarallowreadonhost sets. Look, it made sense at the time.However, it means there are different potential meanings for what can go into
ids, and that in turn makes it confusing to explain pins and can lead to subtle misunderstandings due to e.g. mismatched types.This change allows
pinsto be used instead, which makes it very explicit what the intention is. Internally, for backwards compatibility, the behavior is very similar to pinning withidswith a few extra guardrails -- something we could consider changing in the future if we want, although we'd have to do it at the API level to ensure existing grants work -- but lets the user be more specific and expressive as to intent.PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.