Skip to content

Backport of fix(audit): populate email/name in audit events into release/0.21.x#6702

Open
hc-github-team-secure-boundary wants to merge 1 commit into
release/0.21.xfrom
backport/louis-auth/formerly-neat-emu
Open

Backport of fix(audit): populate email/name in audit events into release/0.21.x#6702
hc-github-team-secure-boundary wants to merge 1 commit into
release/0.21.xfrom
backport/louis-auth/formerly-neat-emu

Conversation

@hc-github-team-secure-boundary
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #6692 to be assessed for backporting due to the inclusion of the label backport/0.21.x.

The below text is copied from the body of the original PR.


Description

Fixes two bugs around auth data being populated in audit events:

  • The first bug was making use of a userData local variable that was never actually populated with the user data
  • The second bug was that when we added support for ldap we never updated the iam_acct_info view to grab the full name and email from the table

These bugs were never caught because the test excising this path used the default redaction rules to set fullName and email to <redacted>. Note that we do also redact empty strings.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

Overview of commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants