Update bootstrap configuration for HCP Telemetry#122
Merged
Conversation
Contributor
|
This may also need to be backported to 1.0.x? #90 was back ported to 1.0.x |
added 2 commits
May 25, 2023 11:41
chapmanc
added
backport/1.0
backport/1.1
freddygv
approved these changes
May 25, 2023
Contributor
freddygv
left a comment
freddygv
left a comment
There was a problem hiding this comment.
LGTM, one minor comment about the changelog entry
| @@ -0,0 +1,3 @@ | |||
| ```release-note:improvement | |||
| Update bootstrap configuration. | |||
Contributor
There was a problem hiding this comment.
Can this mention the rename, since there's a previous changelog entry about it?
https://github.com/hashicorp/consul-dataplane/blob/main/.changelog/90.txt
This was referenced May 25, 2023
curtbushko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran make copy-bootstrap-config to update the consul config