Skip to content

[CC-4361] Add HCPMetricsBindSocketDir to Envoy bootstrap config #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Achooo merged 4 commits into from
Mar 14, 2023
Merged

[CC-4361] Add HCPMetricsBindSocketDir to Envoy bootstrap config #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6f02df
Add HCPMetricsBindSocketDir to Envoy bootstrap config
Achooo Mar 7, 2023
8f2ab52
Namespace is never empty. Fix test and build path without if check
Achooo Mar 9, 2023
445aaf7
reuse constant test
Achooo Mar 9, 2023
f2bd67c
use path.Join to simplify code
Achooo Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/90.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
```release-note:feature
Add envoy_hcp_metrics_bind_socket_dir flag to configure a directory where a unix socket is created.
This enables Envoy metrics collection, which will be forwarded to a HCP metrics collector.
```
63 changes: 62 additions & 1 deletion internal/bootstrap/bootstrap_config.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading