update config defaults, add docs#15302
Merged
Merged
Conversation
github-actions
Bot
added
theme/config
hashi-derek
reviewed
Nov 8, 2022
Contributor
|
Hi @malizz Thanks for doing this, could we also call out the connect and cluster peering defaults as breaking changes in our changelog. In our upgrade specific guideline, we should also note that during upgrades those settings must be set to false prior to the upgrade if you do not want to enable such functionality. |
Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com>
Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com>
david-yu
reviewed
Nov 8, 2022
hashi-derek
reviewed
Nov 9, 2022
hashi-derek
reviewed
Nov 9, 2022
hashi-derek
approved these changes
Nov 9, 2022
erichaberkorn
approved these changes
Nov 9, 2022
| release. Refer to `grpc_tls` for more information on configuring a TLS-enabled port. | ||
| - `grpc_tls` ((#grpc_tls_port)) - The gRPC API with TLS connections, -1 to disable. Default -1 (disabled). | ||
| **We recommend using `8502` for `grpc_tls`** as your conventional gRPC port number, as it allows some | ||
| - `grpc_tls` ((#grpc_tls_port)) - The gRPC API with TLS connections, -1 to disable. gRPC_TLS is enabled by default on port 8503 for Consul servers. |
Contributor
There was a problem hiding this comment.
Suggested change
| - `grpc_tls` ((#grpc_tls_port)) - The gRPC API with TLS connections, -1 to disable. gRPC_TLS is enabled by default on port 8503 for Consul servers. | |
| - `grpc_tls` ((#grpc_tls_port)) - The gRPC API with TLS connections, -1 to disable. `grpc_tls` is enabled by default on port 8503 for Consul servers. |
This is probably a bit more consistent.
| files#grpc_port) configuration **will stop supporting encryption in a future release**. As of version 1.14, | ||
| `ports.grpc_tls` is the recommended configuration to encrypt gRPC traffic. | ||
| [`ports.grpc_tls`](/docs/agent/config/config-files#grpc_tls_port) is the recommended configuration to encrypt gRPC traffic. | ||
| The default value for gRPC TLS port is 8503 for Consul servers. To disable the gRPC TLS port, use value -1. |
Contributor
There was a problem hiding this comment.
Suggested change
| The default value for gRPC TLS port is 8503 for Consul servers. To disable the gRPC TLS port, use value -1. | |
| The default gRPC TLS port is 8503 for Consul servers. To disable the gRPC TLS port, use value -1. |
3 tasks
hashi-derek
added a commit
that referenced
this pull request
Nov 10, 2022
* update config defaults, add docs * update grpc tls port for non-default values * add changelog * Update website/content/docs/upgrading/upgrade-specific.mdx Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com> * Update website/content/docs/agent/config/config-files.mdx Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com> * update logic for setting grpc tls port value * move default config to default.go, update changelog * update docs * Fix config tests. * Fix linter error. * Fix ConnectCA tests. * Cleanup markdown on upgrade notes. Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com> Co-authored-by: Derek Menteer <derek.menteer@hashicorp.com>
hashi-derek
added a commit
that referenced
this pull request
Nov 10, 2022
* update config defaults, add docs * update grpc tls port for non-default values * add changelog * Update website/content/docs/upgrading/upgrade-specific.mdx Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com> * Update website/content/docs/agent/config/config-files.mdx Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com> * update logic for setting grpc tls port value * move default config to default.go, update changelog * update docs * Fix config tests. * Fix linter error. * Fix ConnectCA tests. * Cleanup markdown on upgrade notes. Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com> Co-authored-by: Derek Menteer <derek.menteer@hashicorp.com> Co-authored-by: malizz <maliheh.monshizadeh@hashicorp.com> Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com> Co-authored-by: Derek Menteer <derek.menteer@hashicorp.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change 1.14 Config Defaults
PR Checklist