Skip to content

[Manual backport] Net 3478/backport service instances table#16841

Merged
JadhavPoonam merged 1 commit into
release/1.13.xfrom
NET-3478/backport-service-instances-table
Apr 3, 2023
Merged

[Manual backport] Net 3478/backport service instances table#16841
JadhavPoonam merged 1 commit into
release/1.13.xfrom
NET-3478/backport-service-instances-table

Conversation

@JadhavPoonam
Copy link
Copy Markdown
Contributor

@JadhavPoonam JadhavPoonam commented Mar 31, 2023

Description

The backport label on 1.14 PR did not generate a backport PR here so I have to create this manually.
Also, some of the changes were not easily back portable:

  • The ServiceUsage method in state->usage.go function does not take memdb.WatchSet parameter
  • The firstUsageEntry function also does not takememdb.WatchSet param
  • The xdscapacity directory does not exist in 1.13.x

Testing & Reproduction steps

Links

Cherry-picked commit from release 1.14.x: #16819

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@JadhavPoonam JadhavPoonam force-pushed the NET-3478/backport-service-instances-table branch from d78a08e to 4ef6d64 Compare March 31, 2023 21:32
@JadhavPoonam JadhavPoonam changed the title [Manual backport] WIP: backport service instances table [Manual backport] Net 3478/backport service instances table Mar 31, 2023
@JadhavPoonam JadhavPoonam marked this pull request as ready for review March 31, 2023 21:33
@JadhavPoonam JadhavPoonam merged commit 1d6f8ab into release/1.13.x Apr 3, 2023
@JadhavPoonam JadhavPoonam deleted the NET-3478/backport-service-instances-table branch April 3, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants