docs: fixup note about node scope for admin partitions#17147
Merged
Conversation
github-actions
Bot
added
the
type/docs
david-yu
approved these changes
Apr 26, 2023
Contributor
david-yu
left a comment
david-yu
left a comment
There was a problem hiding this comment.
I believe this needs to be back ported all the way to at least 1.13.x (current latest maintained version of Consul)
david-yu
added
pr/no-changelog
This was referenced Apr 26, 2023
Closed
Closed
Contributor
|
Sometimes, the effort to backport isn't worth it for certain docs changes. A lot of our docs have been significantly changed (or even renaming / moved / broken up) between main and the last few releases. It's worth attempting the auto-backport, but fixing up others manually is a judgment call. (I'd personally say this one isn't worth manually backporting.) |
Contributor
|
Yea at least 1.15.x should have this, I think this is another instance of the backport assistant failing for certain branches. |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixup an inaccurate note about nodes being scoped to namespaces.
Testing & Reproduction steps
Links
PR Checklist