Use auth context when evaluating permissions for service config resolution#17207
Merged
Conversation
Co-Authored-By: Blake Covarrubias <1812+blake@users.noreply.github.com>
Member
Author
|
I will add test coverage when I get some time. Leaving in draft until then 🚀 |
nathancoleman
changed the title
nathancoleman
added
the
pr/no-changelog
Member
Author
|
This change is a no-op for OSS. Given that, I've added tests and a changelog entry for the Enterprise offering only. |
boxofrad
approved these changes
May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the auth context is not used when evaluating permissions, service resolution is failing whenever it should be evaluated in a non-default partition.
Testing & Reproduction steps
Links
PR Checklist