fix(connect envoy): set initial_fetch_timeout to wait for initial xDS…#17317
Merged
Conversation
github-actions
Bot
added
the
theme/cli
DanStough
force-pushed
the
dans/NET-3917/default-0s-initial_fetch_timeout
branch
from
91fbad1 to
530d192
Compare
komapa
reviewed
May 12, 2023
Co-authored-by: Kiril Angov <kiril.angov@gmail.com>
zalimeni
approved these changes
May 12, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consul updates for #17283. Consul dataplane updates to follow.
This changes the time Envoy waits for the initial xDS configuration from the default (15s) to indefinitely. This prevents Envoy from starting with only a partial list of listeners/clusters.
Testing & Reproduction steps
Goldenfile tests have been updated since this affects Envoy's bootstrap configuration.
PR Checklist
external facing docs updated