Rename hcp-metrics-collector to consul-telemetry-collector

[clly]

Description

We originally named the collector service name as hcp-metrics-collector. Rename the service name to follow the intended project name.

Also renamed the bind_socket_dir config key to remove the hcp reference. The collector can be used without HCP so it made sense to generalize the name

Testing & Reproduction steps

• Unit tests have been modified to ensure everything passes.
• Tested locally as follows:

1. Run consul agent in dev mode: bin/consul agent -dev
2. Register services:

• web service: consul services register web.json

  {
  "service": {
      "name": "web",
      "port": 9191,
      "connect": {
          "sidecar_service": {
              "proxy": {
                  "config": {
                      "envoy_telemetry_collector_bind_socket_dir": "/Users/ashvitha.sridharan/tmp/"
                  }
              }
          }
      }
  }

}```

• collector service: consul services register collector.json

{    "service":{
      "name": "consul-telemetry-collector",
      "port": 9090,
      "connect": {
          "sidecar_service": {
          }
      }
  }
}

2. Run sidecars

• ./bin/consul connect envoy -sidecar-for web -- -l debug
• ./bin/consul connect envoy -admin-bind localhost:19001 -sidecar-for consul-telemetry-collector -- -l debug

3. Run a mock metric handler (grpc service) and see metrics flow:
4. 

Links

PR Checklist

• updated test coverage
• external facing docs updated
• appropriate backport labels added
• not a security concern

[Achooo]

This should have been the right place to have the docs, so the docs were moved from website/content/commands/connect/envoy.mdx to this file.

[trujillo-adam]

Minor suggestions for the docs.

[trujillo-adam]

Suggested change

	- `envoy_telemetry_collector_bind_socket_dir` - Specifies the directory where Envoy creates a unix socket.
	Envoy sends metrics to the socket with which a consul telemetry collector can collect them.
	The socket is not configured by default.
	- `envoy_telemetry_collector_bind_socket_dir` - Specifies the directory where Envoy creates a Unix socket.
	Envoy sends metrics to the socket where a Consul telemetry collector can collect them.
	The socket is not configured by default.

If I'm not mistaken, Unix is a proper noun.

[trujillo-adam]

Docs LGTM!

[freddygv]

LGTM

[curtbushko]

LGTM!

You are re-naming everything and nothing is jumping out at me.