support ent debug mode#17411
Merged
Merged
Conversation
xwa153
added
pr/no-changelog
dhiaayachi
approved these changes
May 24, 2023
Contributor
dhiaayachi
left a comment
dhiaayachi
left a comment
There was a problem hiding this comment.
LGTM! Thank you for fixing this @wangxinyi7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, @dhiaayachi introduced the convenient debugging mode that supports people debug the consul code in the integration test.
However it only supports the OSS version as the image adopted by ent is different. This PR extends the capability and removes some redundancy.
PR Checklist
updated test coverageexternal facing docs updatedappropriate backport labels added