Skip to content

[OSS] gRPC Blocking Queries#17426

Merged
DanStough merged 2 commits into
mainfrom
dans/NET-1948/blocking-queries-attempt-3
May 23, 2023
Merged

[OSS] gRPC Blocking Queries#17426
DanStough merged 2 commits into
mainfrom
dans/NET-1948/blocking-queries-attempt-3

Conversation

@DanStough
Copy link
Copy Markdown
Contributor

@DanStough DanStough commented May 22, 2023

Description

This PR adds blocking support to gRPC endpoints used for peering. Currently, these poll at a constant 1s interval. This is too slow for mesh gateway updates when using PeerThroughMeshGateways and too fast for steady-state updates that may trigger disco-chain compilation.

Testing & Reproduction steps

  • CI automated test
  • You can manually curl the HTTP endpoints using blocking query semantics and observe updates only on change.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@DanStough DanStough changed the title feat: initial grpc blocking queries [OSS] feat: initial grpc blocking queries May 22, 2023
@DanStough DanStough requested a review from a team as a code owner May 22, 2023 18:59
@DanStough DanStough force-pushed the dans/NET-1948/blocking-queries-attempt-3 branch from dd85cb9 to c14efa4 Compare May 22, 2023 19:54
@DanStough DanStough force-pushed the dans/NET-1948/blocking-queries-attempt-3 branch from c14efa4 to e3df1d8 Compare May 23, 2023 18:14
@DanStough DanStough changed the title [OSS] feat: initial grpc blocking queries [OSS] gRPC Blocking Queries May 23, 2023
@DanStough DanStough requested a review from hashi-derek May 23, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants