[HCP Observability] Add safety checks for TelemetryConfig payload response#17511
Merged
Conversation
Achooo
force-pushed
the
fix-hcp-client-telemetry-cfg-checks
branch
from
1521434 to
f7e83d6
Compare
Achooo
changed the title
chapmanc
approved these changes
May 30, 2023
Contributor
chapmanc
left a comment
chapmanc
left a comment
There was a problem hiding this comment.
LGTM thanks for making this safer!!
jmurret
approved these changes
May 30, 2023
Member
jmurret
left a comment
jmurret
left a comment
There was a problem hiding this comment.
👏 approving, but please remove the changelog before merging. See additional comment.
Member
There was a problem hiding this comment.
I would remove the changelog entry since you are making a modification to an unreleased feature. So basically this is a change that customers won't need to know about. Basically, the whole feature should get one changelog entry for the feature being released rather than several smaller updates with every PR.
Please remove this entry file and add the pr/no-changelog label to the PR.
Contributor
Author
There was a problem hiding this comment.
Sounds good! thank you :D
Achooo
force-pushed
the
fix-hcp-client-telemetry-cfg-checks
branch
from
dabe913 to
f7e83d6
Compare
Achooo
added
the
pr/no-changelog
Achooo
force-pushed
the
fix-hcp-client-telemetry-cfg-checks
branch
from
f7e83d6 to
94998be
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #17460
This PR adds safety checks in the event that the Telemetry Gateway is down, or the client does not return an error, we should have the response validated.
Testing & Reproduction steps
Links
PR Checklist