Add Upstream Service Targeting to Property Override Extension#17517
Merged
Conversation
* Also add baseline goldens for service specific property override extension. * Refactor the extension framework to put more logic into the templates.
erichaberkorn
added
pr/no-changelog
zalimeni
approved these changes
May 30, 2023
erichaberkorn
force-pushed
the
upstream-svc-targeting-prop-override
branch
from
1442bdf to
a618903
Compare
erichaberkorn
force-pushed
the
upstream-svc-targeting-prop-override
branch
from
a618903 to
cc8c13a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for targeting specific services from the property override extension. It also refactors a lot of the property override extension's logic into Envoy extension templates. This should greatly simplify writing future extensions.
The golden file diffs all live here 1442bdf?w=1