Skip to content

fix isServer to exclude local address#17519

Merged
dhiaayachi merged 1 commit into
mainfrom
rate-limiter-ip/fix_local_ip_update_cfg
May 30, 2023
Merged

fix isServer to exclude local address#17519
dhiaayachi merged 1 commit into
mainfrom
rate-limiter-ip/fix_local_ip_update_cfg

Conversation

@dhiaayachi
Copy link
Copy Markdown
Contributor

Description

This change the isServer behaviour to only return true when other servers IP detected. This to account for the use case when a server is receiving requests from its local IP.

@dhiaayachi dhiaayachi added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels May 30, 2023
Copy link
Copy Markdown
Contributor

@xwa153 xwa153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dhiaayachi dhiaayachi merged commit 04a0d01 into main May 30, 2023
@dhiaayachi dhiaayachi deleted the rate-limiter-ip/fix_local_ip_update_cfg branch May 30, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants