Skip to content

Add FIPS to dataplane features#17522

Merged
skpratt merged 1 commit into
mainfrom
skpratt/fips-dataplane-feature
May 31, 2023
Merged

Add FIPS to dataplane features#17522
skpratt merged 1 commit into
mainfrom
skpratt/fips-dataplane-feature

Conversation

@skpratt
Copy link
Copy Markdown
Contributor

@skpratt skpratt commented May 30, 2023

Description

Rather than a direct version query to determine compatibility with Consul, Dataplane uses a separate feature advertising system. This adds FIPS to that list.

Testing & Reproduction steps

No behavior changes.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@skpratt skpratt force-pushed the skpratt/fips-dataplane-feature branch from ba4c0db to 38153e1 Compare May 30, 2023 22:49
@skpratt skpratt added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels May 30, 2023
@skpratt skpratt marked this pull request as ready for review May 30, 2023 22:53
@skpratt skpratt requested review from DanStough and jshahriddhi May 30, 2023 22:53
@skpratt skpratt force-pushed the skpratt/fips-dataplane-feature branch 6 times, most recently from 56227de to 66fd15e Compare May 31, 2023 14:21
@skpratt skpratt force-pushed the skpratt/fips-dataplane-feature branch from 66fd15e to 3db4522 Compare May 31, 2023 15:15
Copy link
Copy Markdown
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skpratt skpratt merged commit a065eef into main May 31, 2023
@skpratt skpratt deleted the skpratt/fips-dataplane-feature branch May 31, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants