Skip to content

Backport of Fix metric names in Consul agent telemetry docs into release/1.15.x#17590

Merged
im2nguyen merged 2 commits into
release/1.15.xfrom
backport/jjtimmons/fix-metric-periods/specially-game-boxer
Jun 13, 2023
Merged

Backport of Fix metric names in Consul agent telemetry docs into release/1.15.x#17590
im2nguyen merged 2 commits into
release/1.15.xfrom
backport/jjtimmons/fix-metric-periods/specially-game-boxer

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #17577 to be assessed for backporting due to the inclusion of the label backport/1.15.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@jjtimmons
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "bed7863d488c1f51a21570c78afe9d4cf0ec7251", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

A seemingly random subset of counters have a . in their name which is incorrect (the metric names don't end in .)

Testing & Reproduction steps

Checked and a couple of these metrics do not, in fact, end in periods:

Screenshot 2023-06-05 at 5 30 13 PM

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/jjtimmons/fix-metric-periods/specially-game-boxer branch from 1e7f5d5 to 5556d21 Compare June 6, 2023 18:43
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/jjtimmons/fix-metric-periods/specially-game-boxer branch from 2582606 to da14817 Compare June 6, 2023 18:43
@github-actions github-actions Bot added the type/docs Documentation needs to be created/updated/clarified label Jun 6, 2023
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel Bot temporarily deployed to Preview – consul-ui-staging June 6, 2023 18:46 Inactive
@vercel vercel Bot temporarily deployed to Preview – consul June 6, 2023 18:53 Inactive
@im2nguyen im2nguyen marked this pull request as ready for review June 13, 2023 01:32
@im2nguyen im2nguyen requested a review from a team as a code owner June 13, 2023 01:32
@im2nguyen im2nguyen merged commit df69d18 into release/1.15.x Jun 13, 2023
@im2nguyen im2nguyen deleted the backport/jjtimmons/fix-metric-periods/specially-game-boxer branch June 13, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants