Skip to content

Disable terminating-gateway for property-override#17605

Merged
zalimeni merged 1 commit into
mainfrom
zalimeni/disable-tgw-property-override
Jun 7, 2023
Merged

Disable terminating-gateway for property-override#17605
zalimeni merged 1 commit into
mainfrom
zalimeni/disable-tgw-property-override

Conversation

@zalimeni
Copy link
Copy Markdown
Member

@zalimeni zalimeni commented Jun 7, 2023

More validation is needed to ensure this behaves as expected; in the meantime, align with docs and disable this proxy type.

Description

Disable configuring terminating-gateway in the property-override builtin Envoy extension.

PR Checklist

  • updated test coverage
  • external facing docs updated - separate change
  • appropriate backport labels added
  • not a security concern

More validation is needed to ensure this behaves as expected; in the
meantime, align with docs and disable this proxy type.
@zalimeni zalimeni added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. pr/no-backport labels Jun 7, 2023
@zalimeni zalimeni requested a review from erichaberkorn June 7, 2023 19:21
@zalimeni zalimeni marked this pull request as ready for review June 7, 2023 19:21
@zalimeni zalimeni enabled auto-merge (squash) June 7, 2023 19:21
@zalimeni zalimeni merged commit 1db02a0 into main Jun 7, 2023
@zalimeni zalimeni deleted the zalimeni/disable-tgw-property-override branch June 7, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. pr/no-metrics-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants