Update submodules for 1.16.0-rc1 release#17626
Merged
Merged
Conversation
github-actions
Bot
added
the
pr/dependencies
zalimeni
force-pushed
the
release-1.16.0-rc1-submodule-updates
branch
from
f3e0669 to
f4a9bad
Compare
zalimeni
changed the title
zalimeni
added
pr/no-changelog
zalimeni
force-pushed
the
release-1.16.0-rc1-submodule-updates
branch
from
f4a9bad to
a4c5c22
Compare
Update to new RC submodule versions. These will be updated again for the 1.16.0 release.
zalimeni
force-pushed
the
release-1.16.0-rc1-submodule-updates
branch
from
a4c5c22 to
11cfb05
Compare
nathancoleman
approved these changes
Jun 8, 2023
Member
There was a problem hiding this comment.
Ran through the same process on my machine over Zoom. LGTM
Notably, some Consul releases have left the replace directives commented out and some have not. It seems to me that leaving them commented out is the "right" call so that the versions of the submodules being used by consul are those pinned in go.mod instead of the local directories; otherwise, there's no point to pinning the submodules in /go.mod at all because the code from the local directories will be used instead.
Member
Author
|
@nathancoleman I agree, I think this is a docs opportunity for future releases. I'll check that everything is happy once CI runs for these, and may re-cut the tags tomorrow to comment out |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating submodules, solely on the running release branch, as this is the only branch that should consume the RC submodule tags.